Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onion text and change IPFS icon #12261

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Update Onion text and change IPFS icon #12261

merged 1 commit into from
Feb 15, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 15, 2022

Resolves brave/brave-browser#21092

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Open brave.com in Tor mode

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue says use the same "icon" not changing the name of "Onion Available"
IPFS is currently using the different icon

@bbondy
Copy link
Member

bbondy commented Feb 15, 2022

I think it probably makes sense to have consistent icon and also text. cc @jamesmudgett for thoughts.

@spylogsster spylogsster marked this pull request as draft February 15, 2022 17:28
@jamesmudgett
Copy link
Collaborator

".onion" or "Load .onion" vs "Onion"

@spylogsster spylogsster changed the title Rename Onion button WIP: Rename Onion button Feb 15, 2022
@spylogsster spylogsster changed the title WIP: Rename Onion button Update Onion text and change IPFS icon Feb 15, 2022
@spylogsster spylogsster marked this pull request as ready for review February 15, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS, Tor, and Onion icons should be the same (all open new tabs)
4 participants